Skip to content

Captcha: Added integration test for checking admin login attempts cleanup#16300

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
rogyar:2.2-captcha-reset-admin-it
Jun 24, 2018
Merged

Captcha: Added integration test for checking admin login attempts cleanup#16300
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
rogyar:2.2-captcha-reset-admin-it

Conversation

@rogyar
Copy link
Copy Markdown
Contributor

@rogyar rogyar commented Jun 21, 2018

Description

The integration test checks that the admin login attempts are being removed after a successful login

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 21, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Jun 21, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2087 has been created to process this Pull Request

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @rogyar. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants